Adding Gen 6 Ambush Encounters#1576
Conversation
jemarq04
left a comment
jemarq04
left a comment
There was a problem hiding this comment.
Looking through the encounters, there are quite a few off-by-one errors when it comes to the encounter methods (e.g. some ID 56 overworld-dirt that should be ID 57 trash-can). Once you fix these up, I'll take another look. Thanks!
| 257,26,berry-tree-red,1 | ||
| 258,26,berry-tree-blue,1 | ||
| 259,26,berry-tree-purple,1 | ||
| 260,26,berry-tree-green,1 | ||
| 261,26,berry-tree-yellow,1 | ||
| 262,26,berry-tree-pink,1 | ||
| 263,27,daily-trash-can,1 | ||
| 264,27,tuesday-trash-can,1 | ||
| 265,27,thursday-trash-can,1 No newline at end of file |
There was a problem hiding this comment.
Generally the encounter condition values' identifiers start with the encounter condition identifier. For example, for berry-tree-type we'd use something like berry-tree-type-blue and so on.
There was a problem hiding this comment.
Okay, I'll adjust them something like trash-can-type-daily.
| 18,gift,18 | ||
| 19,gift-egg,19 | ||
| 20,only-one,20 | ||
| 20,static-encounter,20 |
There was a problem hiding this comment.
| 20,static-encounter,20 | |
| 20,static,20 |
Maybe just 'static', since these are all methods for encountering pokemon.
There was a problem hiding this comment.
Okay, sounds good. I'll also change sos-encounter to just say sos to match as well.
There was a problem hiding this comment.
Hmm. I missed that lol. Well, if it wasn't consistent before, we can leave this as-is!
Edit: I worded this wrong, but basically if we have something else with 'encounter' in it then it's up to you
| 57,trash-can,57 | ||
| 58,rustling-bush-ambush,58 | ||
| 59,ceiling-ambush,59 | ||
| 60,ground-ambush,60 | ||
| 61,sky-ambush,61 No newline at end of file |
There was a problem hiding this comment.
This is a great start on the new methods! Looking at Bulbapedia, some of these are even used again in Alola, so this will be helpful there too.
Regarding the names, maybe they should all contain 'ambush'? So something like trash-can-ambush? That way they can be understood as a group at a glance.
Looks like I didn't take the previous method into account. I shifted everything up correctly. I'll push once I confirm it builds correctly and is set to the right methods. |
2 participants
Change description
This PR consists of the X and Y Ambush encounters that were missing.
This includes additions of new Encounters, Encounter Methods, and Encounter Conditions.
This would close Issue #1454.
AI coding assistance disclosure
No AI was used in adding these.
Contributor check list